Aruco 3.0.4 #44
Aruco 3.0.4 #44
Conversation
v-lopez
force-pushed
the
aruco-3.0.4
branch
4 times, most recently
from
09d8177 to
4a2cc03
Compare
|
@bmagyar Any feelings about this? |
|
A code change of this magnitude cannot be reviewed in the usual way. There's one thing I've spotted though: the optimal markers tool seems to be gone. What's the recommended way to generate new (sets of) markers now? |
|
@bmagyar I haven't been able to find a substitute for the selectoptimal markers tool in the latest aruco version. |
Sets the 'useRectifiedImages' member from a parameter before it uses it
Autoformatting as per CppStyleGuide
|
@bmagyar I'm working on some more major changes on top of this. At this point I'm torn between setting this branch as melodic-devel, putting all in a fork and leave this intact, or making an aruco3_ros package or something, starting from this. I want to make quite a bit of backward incompatible changes in the launch files that are due from long time ago, like allowing full topic names as input of launch files, instead of "side", removing hard coded frames.. Also restructuring the code and making some functions reusable from outside the nodes in a library. What are your thoughts? |
|
"Let the past die, kill it, if you have to."
Don't make a new package with a version in the name, those are always
confusing.
…On Tue, 21 Jan 2020, 11:52 Victor Lopez, ***@***.***> wrote:
@bmagyar <https://github.com/bmagyar> I'm working on some more major
changes on top of this. At this point I'm torn between setting this branch
as melodic-devel, putting all in a fork and leave this intact, or making an
aruco3_ros package or something, starting from this.
I want to make quite a bit of backward incompatible changes in the launch
files that are due from long time ago, like allowing full topic names as
input of launch files, instead of "side", removing hard coded frames.. Also
restructuring the code and making some functions reusable from outside the
nodes in a library.
What are your thoughts?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#44?email_source=notifications&email_token=AA24PYJUQOMOR4XZT3DPRTLQ63OZFA5CNFSM4EPSIJM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJPPGKQ#issuecomment-576647978>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA24PYI3YNG6PLTZCLFOCALQ63OZFANCNFSM4EPSIJMQ>
.
|
No description provided.